BoxCloneService router pipeline improvements#9169
Draft
rohan-b99 wants to merge 10 commits intorohan-b99/use-BoxCloneServicefrom
Draft
BoxCloneService router pipeline improvements#9169rohan-b99 wants to merge 10 commits intorohan-b99/use-BoxCloneServicefrom
rohan-b99 wants to merge 10 commits intorohan-b99/use-BoxCloneServicefrom
Conversation
…rService::new()`
…vice is now used
…longer requires `buffered`
…ponse_cache tests as clone no longer occurs
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 5 changed, 0 removedBuild ID: e70d43d83bc380d888b89990 URL: https://www.apollographql.com/docs/deploy-preview/e70d43d83bc380d888b89990 ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
rohan-b99
commented
Apr 10, 2026
Comment on lines
+966
to
+969
| tower::service_fn(|_req: subgraph::Request| async { | ||
| Err::<subgraph::Response, _>("orga not found".into()) | ||
| }) | ||
| .boxed_clone() |
Contributor
Author
There was a problem hiding this comment.
Need to double check this change (and the similar one in response_cache) is OK as an expectation is being removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bufferedcalls where no longer neededMakeSubgraphServiceandMakeHttpServicetraitsChecklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩